fix: remove reset logic which cleared all slots #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Encountered a bug where if a file went from having one label (tag) to no labels then a validation error would appear and all tags would be lost - Discovered that in these cases resetAllSlots was being called causing this behaviour - Removed the reset all logic which resolved the bug
- The `updatedFileList` was being defined but the value of that defintion was never being used - Removed the definition and added repetition but hopefully leaving more readable code.
|
Removed vultr server and associated DNS entries |
- Found that merge with a single argument was shallow copying - This lead to us directly updating the fileList - Changed to `cloneDeep` as there was already precedence within the file - As per #1811 structuredClone not yet supported in our stack
DafyddLlyr
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resetAllSlotslogic fromupdateFileListWithTags.updatedFileListfromupdateFileListWithTags.merge(fileList)tocloneDeep(fileList)Why
resetAllSlotswhich would wipe the tags applied to all files.mergetocloneDeepasmergewas not a deep clone leading us to mutate state directly.updatedFileListfrom theupdateFileListWithTagsfunction as the initial value was never used.Screen recordings
Bug recording:
#2209 (comment)
Fix recording:
Screen.Recording.2023-10-30.at.15.54.57.mov