fix: Don't overwrite req with parsedReq

[DafyddLlyr]

What's the problem?

A "reminder" email failed this morning - the reason for this was that the required "email" field was missing from the event sent to Hasura.

What caused this?

This field was missed when typing the schema for this endpoint. This happened as the routeSendEmailRequest() function is not yet typed - meaning the variable was missed.

What's the solution?

• Add "email" to schema
• Add test cases
• Also, don't overwrite req with parsedReq - this change means that non-updated endpoints shouldn't fail as the original req object is not touched. I'm now writing to res.locals (docs) which is a nice solution to the issue I was talking about in a previous dev call. We can now coerce types as part of validation in the middleware, and not break existing endpoints - this feels like a solid solution here.

Next steps...

I think it's pretty likely that multiple reminder and expiry events setup since this change was made are affected by this problem of a missing email field. These events should be identifiable from the Hasura hdb_catalog tables, and we could then append emails to them. I'll update this thread as I troubleshoot this one.

This might also point towards considering a cron job for these events as an alternative to manage reminder and expiry events. Something to consider!

[github-actions]

Removed vultr server and associated DNS entries

[DafyddLlyr]

Right, I've now got some SQL I'm happy with which is tested on staging and locally.

We can run this manually on production once this fix is merged (and the SQL is cross-checked please...!).

Events without an email can be found with this query -

SELECT
  *
FROM
  hdb_catalog.hdb_scheduled_events
WHERE
  webhook_conf::TEXT ILIKE '%expiry%'
  AND status = 'scheduled'
  AND payload->'email' IS NULL;

Records can be updated with -

UPDATE
  hdb_catalog.hdb_scheduled_events
SET
  payload = jsonb_set(
    payload::JSONB,
    '{email}',
    ('"' || public.lowcal_sessions.email || '"')::JSONB
  )
FROM
  public.lowcal_sessions
WHERE
  webhook_conf::TEXT ILIKE '%expiry%'
  AND status = 'scheduled'
  AND payload->'email' IS NULL
  AND hdb_scheduled_events.payload->>'sessionId' = public.lowcal_sessions.id::TEXT;

%expiry% and %reminder% would both need to be run - I guess we could combine them into one query but I'd favour a step by step approach juuust to be safe.

[Mike-Heneghan]

Looks good to me 👍

[Mike-Heneghan]

Question:

Am I right in saying _req is still being passed in despite not being used directly as down the chain it is required?

[DafyddLlyr]

That's correct, _req is always passed in, but no longer used in this instance. We're using the underscore prefix to indicate that this is an unused variable - there's a linting rule set up for this in .eslintrc under @typescript-eslint/no-unused-vars

[Mike-Heneghan]

Right, I've now got some SQL I'm happy with which is tested on staging and locally.

We can run this manually on production once this fix is merged (and the SQL is cross-checked please...!).

Events without an email can be found with this query -

SELECT
  *
FROM
  hdb_catalog.hdb_scheduled_events
WHERE
  webhook_conf::TEXT ILIKE '%expiry%'
  AND status = 'scheduled'
  AND payload->'email' IS NULL;

Records can be updated with -

UPDATE
  hdb_catalog.hdb_scheduled_events
SET
  payload = jsonb_set(
    payload::JSONB,
    '{email}',
    ('"' || public.lowcal_sessions.email || '"')::JSONB
  )
FROM
  public.lowcal_sessions
WHERE
  webhook_conf::TEXT ILIKE '%expiry%'
  AND status = 'scheduled'
  AND payload->'email' IS NULL
  AND hdb_scheduled_events.payload->>'sessionId' = public.lowcal_sessions.id::TEXT;

%expiry% and %reminder% would both need to be run - I guess we could combine them into one query but I'd favour a step by step approach juuust to be safe.

This looks as if it would do what you're intending as far as I can see. Can you remind me where you'd actually run this? Also, I'm happy to jump on a call to go through this 👍

[jessicamcinchak]

Changes & proposed SQL look good to me here 👍

One question about the SQL - the email param is only expected in payloads for session reminders and expiry events, right? Not, payment_ reminder & expiry too? Just double checking we're catching everything expected with this update.

[DafyddLlyr]

One question about the SQL - the email param is only expected in payloads for session reminders and expiry events, right? Not, payment_ reminder & expiry too? Just double checking we're catching everything expected with this update.

This is a good question! I've double checked this and invite to pay emails just need a paymentRequestId and nothing else 👌

planx-new/hasura.planx.uk/metadata/tables.yaml

Lines 895 to 902 in 4e29137

	template: |-
	{
	"createdAt": {{$body.event.data.new.created_at}},
	"payload": {
	"paymentRequestId": {{$body.event.data.new.id}}
	}
	}
	url: '{{$base_url}}/webhooks/hasura/create-payment-invitation-events'

[DafyddLlyr]

I'm going to go ahead and merge this - I'll run the SQL once this has got to production and will then update this PR with a paper trail confirming it's been done successfully.