feat: track a user navigating backwards through flow by node id #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton and store target node data - Users can navigate backwards through a flow to a specific node via the back or change buttons - On click of back or change track the initiator and some metadata of target node by updating the analytics log
Mike-Heneghan
force-pushed
the
mh/analytics-track-back-and-change
branch
from
14fdad3 to
aa669d4
Compare
Mike-Heneghan
changed the title
Mike-Heneghan
commented
Nov 2, 2023
Mike-Heneghan
commented
Nov 2, 2023
| const targetNodeMetadata = getTitleAndTypeFromFlow(nodeId); | ||
| console.log("Target node info: ", targetNodeMetadata); | ||
| const metadata: Record<string, NodeMetadata> = {}; | ||
| metadata[`${initiator}`] = targetNodeMetadata; |
There was a problem hiding this comment.
I opted for this syntax as I was getting errors that the initiator wasn't being used when I was trying to apply is a key in the object creation.
Mike-Heneghan
commented
Nov 2, 2023
Mike-Heneghan
commented
Nov 2, 2023
|
Removed vultr server and associated DNS entries |
1 similar comment
jessicamcinchak
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Apologies it's taken me awhile to properly get to this one, all working as expected on pizza for me and tracking "back" and "change" from both Result & Review 🙌
Feels like a simple structure to extend in the future like you mention for section navigation and "overrides" 💯
| initiator: BackwardsNaviagtionInitiatorType, | ||
| ) { | ||
| const targetNodeMetadata = getTitleAndTypeFromFlow(nodeId); | ||
| console.log("Target node info: ", targetNodeMetadata); |
There was a problem hiding this comment.
nit: looks like this console.log might be a remnant of local dev and can be dropped before merging? one more below on L318 too
- As per #2357 (comment) - Remove unecessary logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
backorchangebutton.backorchangeand store target node metadata i.e.titleandtype.Why
backorchangebutton.Screen Recording
Screen.Recording.2023-11-02.at.12.54.42.mov