Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle bug on first publish #2391

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: Handle bug on first publish #2391

merged 1 commit into from
Nov 7, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 7, 2023 •
edited
Loading

Over eager error handling excluded a use case where mostRecent should be falsy (on first publish)

@DafyddLlyr DafyddLlyr requested a review from a team November 7, 2023 12:17
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 7, 2023 12:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit ea59dce into main Nov 7, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/first-publish-bug branch November 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak