chore: St. Albans key, chain, and cert #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infrastructure/application/index.ts
Outdated
| @@ -52,6 +52,10 @@ const CUSTOM_DOMAINS = | |||
| domain: "planningservices.newcastle.gov.uk", | |||
| name: "newcastle", | |||
| }, | |||
| { | |||
| domain: "stalbans.newcastle.gov.uk", | |||
There was a problem hiding this comment.
Is this right or a copy and paste error?
There was a problem hiding this comment.
Thank you very much! Will fix now
Mike-Heneghan
suggested changes
Nov 8, 2023
DafyddLlyr
force-pushed
the
dp/st-albans-3
branch
from
dba3d1f to
caadc85
Compare
|
Thanks very much for catching that @Mike-Heneghan - clearly time for a walk / coffee / both 😅 Fixed! |
Mike-Heneghan
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Looks good to me 👍
Non-blocking but in a previous PR I think you included an Airbrake config change but I don't think it blocks this.
|
That's correct - it's intentionally left out here. That change is already queued up here once the CDN is generated https://github.com/theopensystemslab/planx-new/pull/2382/files |
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 3...! 🤞
St. Albans have now provided a chain certificate which should resolve the previous issues. Again this has been tested on AWS staging without issues.