Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update subdomain docs and .gitignore #2398

Merged
merged 1 commit into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,10 @@ hasura.planx.uk/.env.test
/playwright-report/
/playwright/.cache/
api.planx.uk/tmp/

# Ignore certificate files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just due to my paranoia when working with these files, I'm always triple checking I'm not adding them to git.

This should prove a handy guard to avoid any major issues as we generally handle *.councilName.gov.uk certificates.

*.chain
*.key
*.pfx
*.pkcs12
*.p12
4 changes: 2 additions & 2 deletions doc/how-to/how-to-setup-custom-subdomains.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ This guide will walk through the process of setting a custom domain for a new te

4. **PlanX** - Format certificates if provided with PKCS #12
```shell
openssl pkcs12 -nocerts -nodes -in <FILENAME> -out council.key [ -password pass:<PASSWORD> ]
openssl pkcs12 -nokeys -in <FILENAME> -out council.cert [ -password pass:<PASSWORD> ]
openssl pkcs12 -nocerts -nodes -in <FILENAME> -out council.key [ -password 'pass:<PASSWORD>' ]
openssl pkcs12 -nokeys -in <FILENAME> -out council.cert [ -password 'pass:<PASSWORD>' ]
```

The `.cert` file might contain the certificate chain inside it, so please separate the first certificate in the file (the certificate body) from the rest of the certificates in the file (the certificate chain).
Expand Down
Loading