Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Analytics column permissions #2403

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 8, 2023

What's the problem?

Cloudwatch is throwing a lot of errors when trying to write analytics logs using the public role. This is due to recent permissions changes.

Ideally, it would be good to get this to production pretty quickly as I think this means certain analytics logs aren't being written currently.

I've made a ticket here to take a closer look at API error handling so that we can be a bit more proactive with some of these issues - https://trello.com/c/TfmJiwID/2686-fix-airbrake-error-logging-on-api

image

@DafyddLlyr DafyddLlyr requested a review from a team November 8, 2023 17:50
Copy link

github-actions bot commented Nov 8, 2023

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (2)

  • public.analytics permissions:

    insert select update delete
    public
    1 added column permissions
    insert select update
    public ➕ ended_at
  • public.analytics_logs permissions:

    insert select update delete
    public / /
    2 added column permissions
    insert select update
    public ➕ user_exit ➕ user_exit

@DafyddLlyr DafyddLlyr marked this pull request as draft November 8, 2023 18:09
@DafyddLlyr DafyddLlyr removed the request for review from a team November 8, 2023 18:09
Copy link

github-actions bot commented Nov 8, 2023

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/analytic-cloudwatch-errors branch from dc00c7e to 6b2c367 Compare November 8, 2023 18:20
@DafyddLlyr DafyddLlyr requested a review from a team November 8, 2023 18:20
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 8, 2023 18:20
@DafyddLlyr DafyddLlyr merged commit 33a3e9b into main Nov 8, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/analytic-cloudwatch-errors branch November 8, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants