Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for new column flows.analytics_link in data sync script #2414

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

jessicamcinchak
Copy link
Member

A manual trigger of the data sync script failed here: https://github.com/theopensystemslab/planx-new/actions/runs/6849674665/job/18622337310#step:9:99

This is a bit of a tedious process:

  • First we select * from flows in scripts/seed_database/container.sh
  • Then, consequently, the specific list of columns in scripts/seed_database/write/flows.sql need to match *, even for columns like analytics_link where we don't want to sync the actual value across envs

I tested locally by running pnpm test-sync in the project root

Copy link

github-actions bot commented Nov 13, 2023

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit c79e639 into main Nov 13, 2023
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/sync-flows-analytics-link-col branch November 13, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants