Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flows API module #2419

Merged
merged 11 commits into from
Nov 17, 2023
Merged

feat: Flows API module #2419

merged 11 commits into from
Nov 17, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 14, 2023

What does this PR do?

  • Documents the flows module (move, copy, validate, publish etc)
  • Splits code into controllers (handle HTTP requests) and services (business logic)
  • Adds validation to the /flows endpoints
  • Standardise a few response types
  • Splits up validate and publish functionality into their own files
  • No functional changes!

image

Copy link

github-actions bot commented Nov 14, 2023

Removed vultr server and associated DNS entries

flowId: z.string(),
}),
body: z.object({
replaceValue: z.string().length(5),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly controlling the length here to 5 matches the current frontend behaviour, and has meant that a few test cases need nodeIds tweaked below.

I'll double check the onboarding scripts to enforce this to 5 characters there as well once this is merged.

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & all working as expected on pizza, thanks again for working through all these !

@DafyddLlyr
Copy link
Contributor Author

Thanks for review - kept in draft as I hit a small issue with the download-schema endpoint. Looking at it again now and will push a fix to this branch shortly.

Copy link

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • public.flow_schemas permissions:

    insert select update delete
    public /
    1 added column permissions
    insert select update
    public ➕ text

Untracked Tables (1)

  • public.submission_services_summary

@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 17, 2023 10:08
@DafyddLlyr DafyddLlyr merged commit 20d5f22 into main Nov 17, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/flows-module branch November 17, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants