Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platformAdmin and teamEditor roles need to be able to update flows.team_id for "move" functionality #2423

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Nov 14, 2023

Reported here https://opendigitalplanning.slack.com/archives/C0241GWFG4B/p1699976778720039

Testing:

  • As a platform admin you can "move" a flow to any team
  • As a team editor you can "move" a flow to any team you have edit access to

Copy link

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • public.flows permissions:

    insert select update delete
    platformAdmin /
    teamEditor /
    2 added column permissions
    insert select update
    platformAdmin ➕ team_id
    teamEditor

@jessicamcinchak jessicamcinchak changed the title fix: platformAdmin and teamEditor roles need to be able to update flows.team_id for "copy" functionality fix: platformAdmin and teamEditor roles need to be able to update flows.team_id for "move" functionality Nov 14, 2023
Copy link

github-actions bot commented Nov 14, 2023

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up!

@jessicamcinchak jessicamcinchak merged commit dfb9d5f into main Nov 14, 2023
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/move-flow-permissions branch November 14, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants