Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change undefined to null in confirmationEmailSchema #2438

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix: Change undefined to null in confirmationEmailSchema #2438

merged 2 commits into from
Nov 17, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 17, 2023 •
edited
Loading

What does this PR do?

  • Follow on and fix for chore: Improve email trigger error logging #2436
  • Don't trigger reminder emails if a session is already submitted. We have a guard on these emails to not send, but it's actually simpler if we just don't create events unnecessarily in the first place

@DafyddLlyr DafyddLlyr requested a review from a team November 17, 2023 11:23
@DafyddLlyr DafyddLlyr marked this pull request as draft November 17, 2023 11:24
@DafyddLlyr DafyddLlyr removed the request for review from a team November 17, 2023 11:25
@DafyddLlyr DafyddLlyr force-pushed the dp/update-confirmationEmailSchema-type branch from e48b39e to 5b0ad6f Compare November 17, 2023 11:31
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 17, 2023 11:55
@DafyddLlyr DafyddLlyr mentioned this pull request Nov 17, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit 44a5be8 into main Nov 17, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/update-confirmationEmailSchema-type branch November 17, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak