fix: repeated label removed from file on change click bug #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When the modal was rendered it was incorrectly updating the fileList as the previousTags variable was undefined. - The update function only ever applies a tag to a single file so the second file was not being tagged. - Set the previousTags to the last state or the initialTags on first render - Updates are checked but an update isn't applied as the previousTags = intialTags
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Nov 18, 2023
Mike-Heneghan
deleted the
mh/upload-and-label-change-button-disappearing-duplicate-label-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SelectMultiplecomponent thepreviousTagsare previous state or theinitialTagson first renderWhy
SelectMultiplecomponents and they were incorrectly updating thefileListas thepreviousTagsvariable wasundefinedScreen recordings
Bug
Screen.Recording.2023-11-17.at.17.33.00.mov
Fix
Screen.Recording.2023-11-17.at.17.36.40.mov