feat: Pay and Invite to Pay docs #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 18, 2023
| @@ -82,7 +84,14 @@ export async function fetchPaymentRequestDetails( | |||
| next(); | |||
| } | |||
|
|
|||
| // middleware used by /payment-request/:paymentRequest/pay?returnURL=... | |||
| // https://docs.payments.service.gov.uk/api_reference/create_a_payment_reference/#json-body-parameters-for-39-create-a-payment-39 | |||
There was a problem hiding this comment.
appreciate these comments 👍
DafyddLlyr
force-pushed
the
dp/itp-docs
branch
from
5fac00f to
a059c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I had initially split this into two "Pay" and "Invite to Pay" PRs but as they're quite tightly coupled it proved pretty tricky - the total lines of code changed in two PRs (even with one branching over the other) was significantly higher than a single PR.
Regression tests passing against this branch https://github.com/theopensystemslab/planx-new/actions/runs/6912983715 ✅