fix: Remove empty back bar from confirmation component #2449
Conversation
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/remove-backbar-confirmation
branch
from
65a4f9e to
7d3c424
Compare
| !hasPaid() | ||
| ); | ||
| const { hasPaid, previousCard } = get(); | ||
| return Boolean(node?.id) && Boolean(previousCard(node)) && !hasPaid(); |
There was a problem hiding this comment.
Non-blocking Question:
Is it worth removing the check that the component is a Confirmation from the canGoBack? Part of me wonders if although the back is hidden in this new approach the canGoBack should maybe still be able to be a source of truth over whether it should be possible?
This is maybe silly and over defensive so please feel free to ignore.
There was a problem hiding this comment.
Yeah it's a fair question - my first attempt did just rely on canGoBack().
However there are instances where we want the empty back bar in place for layout reasons, but canGoBack() would return a false - for example the first component in a flow. Without this the layout "jumps" a little which ends up being pretty noticable.
What does this PR do?
This is a small visual thing which has bugged me since we introduced the save and return status pages which have the banner starting at the top of the page, making this look a little inconsistent.
Why not just hide the entire backbar on a single condition?
This would mean that the layout would jump in instances where the back button should be hidden (e.g. first card).