fix: SummaryList bug
#2455
Merged
fix: SummaryList bug
#2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://planx.airbrake.io/projects/329753/groups/3674911676429344553?tab=overview and https://planx.airbrake.io/projects/329753/groups/3672018983332190585?tab=notice-detail
The session caught by the most recent exception had nodeIds in the breadcrumbs which are no longer in the flow which caused this issue. The session does have records in
reconciliation_requestswhich show changes between answered questions and the newly published flow - hence the additional breadcrumbs.I'm going to take a closer look at
removeAlteredAndAffectedBreadcrumb()to try and work out why this breadcrumb wasn't dropped which is the ultimate cause of this issue.