feat: add hasPlanningData property to teams.settings
#2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Nov 19, 2023
| "newcastle", | ||
| "southwark", | ||
| "st-albans", | ||
| ]; |
There was a problem hiding this comment.
I'll update teams.settings.hasPlanningData for these councils on merge ✔️
For testing on this pizza:
- You can successfully fetch constraints for teams setup in Hasura
- Doncaster has
hasPlanningData: true
- Doncaster has
- You see the "{Council} is not a supported local authority" error for teams that have not been setup or are set to false
- Lambeth has
hasPlanningData :false - All other teams currently have undefined
hasPlanningData
- Lambeth has
There was a problem hiding this comment.
Getting the expected results for true, undefined and false values 👍
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As more councils are coming onboard, this change will let us skip PRs for Trello tickets like this one and instead just add the property
"hasPlanningData": truetoteams.settingsin the prod Hasura console for this council. No changes to permissions or the staging data sync are necessary for this to work as expected.We will still open PRs to add API GIS metadata when a council's granular Article 4 variables become available.
Also updated council onboarding step in README here: https://github.com/theopensystemslab/planx-team-onboarding/tree/main#after-running-this-script
Future scope: expose this property via the Team Settings page in the Editor or via admin endpoint in the short term (probably not worth it?)