Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop p-memoize in favour of Apollo caching #2460

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore: Drop p-memoize in favour of Apollo caching #2460

merged 1 commit into from
Nov 20, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 20, 2023 •
edited
Loading

What the problem?

What's the solution?

  • I'm not totally confident that this is the cause but as the query isn't firing it makes sense to try this
  • At minimum we rationalise how we do caching / memoization, drop our bundle size, and rule a variable out of the equation.

@DafyddLlyr DafyddLlyr changed the title chore: Drop p-memoise in favour of Apollo caching chore: Drop p-memoize in favour of Apollo caching Nov 20, 2023
jessicamcinchak
jessicamcinchak approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@DafyddLlyr
Copy link
Contributor Author

Yeah not 100% sure this is the cause but as the query isn't firing it makes sense to try this.

At minimum we rationalise how we do caching / memoization and drop our bundle size.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 20, 2023 11:59
@DafyddLlyr DafyddLlyr merged commit 14a9bf9 into main Nov 20, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-p-memoize branch November 20, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak