Revert "chore: Stream S3 files directly to zip" #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 96adf16.
|
Removed vultr server and associated DNS entries |
Mike-Heneghan
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Looks good to me 👍
Some things I was surprised about but I don't think are anything to do with this piece of work.
The Overview.htm and RedactedOverview.htm are name with .htm rather than .html
I couldn't see how the labels I added to the files could be associated with the uploaded files from what I could see in the zip.
|
Thanks @Mike-Heneghan !
|
jessicamcinchak
deleted the
revert-2380-dp/stream-directly-from-s3-to-zip
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2380 - building this pizza again to see if it introduced issue described here (update: it did): https://opendigitalplanning.slack.com/archives/C0241GWFG4B/p1700561792278499
Fixes issue where user-uploaded files appear not to be included in zip reported in #help-issues. On production, I can still see a
/tmpfolder →{sessionId}_{s3FolderId}folder → user uploaded files, but it sounds like for MS users the/tmpfolder is being hidden altogether !This one was a small tidy up without major performance impacts, so just going to revert & deploy fix for now & will add a Trello ticket to pick back up and solve properly 👌