Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove react-feather icon library #2471

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Nov 22, 2023

What does this PR do?

The app currently uses a mixture of the React Feather and MUI Icons libraries to serve icons.

Instances of React Feather replaced with MUI Icons and dependency removed.

Edit: also updates sizing and margins to increase visual and target size.

Before:
image

After:
image

@ianjon3s ianjon3s requested a review from a team November 22, 2023 14:31
@ianjon3s ianjon3s marked this pull request as ready for review November 22, 2023 14:54
Copy link

github-actions bot commented Nov 22, 2023

Removed vultr server and associated DNS entries

Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🥳

@ianjon3s ianjon3s merged commit f22eaf2 into main Nov 22, 2023
12 checks passed
@ianjon3s ianjon3s deleted the ian/single-icon-library branch November 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants