Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Create an analytics_summary database view for analytics" #2472

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Nov 22, 2023

Reverts #2450

Original merge failed to deploy to staging & Pulumi action was hanging for ~20 minutes until timing out. analytics_summary was never created on dev.

My best guess is that has to do with the renamed migration here? I think the quickest fix is to revert here & just open a fresh PR with the view creation again in a new migration ?

@jessicamcinchak jessicamcinchak requested a review from a team November 22, 2023 15:24
Copy link

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Untracked Tables (1)

  • public.analytics_summary

Copy link

github-actions bot commented Nov 22, 2023

Removed vultr server and associated DNS entries

Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good plan!

I'd incorrectly assumed that git magic would have resolved the naming change but as you say it seems like the most likely culprit.

@jessicamcinchak jessicamcinchak merged commit 736777c into main Nov 22, 2023
12 checks passed
@jessicamcinchak jessicamcinchak deleted the revert-2450-dp/analytics-view branch November 22, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants