fix: sanitise sharedb node data using dompurify
#2478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
commented
Nov 24, 2023
| return trim(x.replace(/[\u200B-\u200D\uFEFF↵]/g, "")); | ||
| } else if ((x && typeof x === "object") || x instanceof Object) { | ||
| return Object.entries(x).reduce((acc, [k, v]) => { | ||
| v = sanitize(v); | ||
| acc[k] = v; |
There was a problem hiding this comment.
This block only return acc, and v = sanitize(v) was indeed sanitizing, but not actually updating the acc which is returned:
- In cases of handling empty values, this didn't matter because we
delete acc[k] - But in cases of sanitising values we want to keep, we need to update the return value too
This was referenced Nov 24, 2023
|
Replaced by #2483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing notes in devops email
Changes:
_addor_updateoperation against SharedDB, we would already "sanitize" values using custom regex to handle empty values. I've added an extra step here to additionally applyDOMPurify.sanitize()on the user data inputs as wellTodo:
DOMPurify.sanitize()too (eg are these methods only catching user input and not interceptions between user input & postgres commands??) - see fix: sanitize sharedb node data usingdompurifyin sharedb.planx.uk #2479