fix: remove sessionId from URLs #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Temporarily removing the feature which allows users to resume on browser refresh - The implementation exposed the sessionId which has security implications - Removed the code for the feature and accompanying test
…rom the url - Exposing the sessionId has security implications - The sessionId and the user email are required to successfully resume their session - Read the sessionId but then immediately remove it from the url. - This means it's barely visible and not dispalyed for the rest of the session
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 27, 2023
| expect(screen.getByText("Testing 123")).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| expect(window.location.href).toContain(`sessionId=${sessionId}`); |
There was a problem hiding this comment.
nit: would it perhaps be more meaningful to flip this test to check not.toContain rather than removing it all together?
- As per: https://github.com/theopensystemslab/planx-new/pull/2485/files/fcc4df227e74eb399d496b3bb14e69a1617f4512#r1406392300 - Reinstate the test as it can add value checking that the sessionId is *not* in the url after being input by user
DafyddLlyr
added a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit 255204a.
DafyddLlyr
added a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why: