Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: help text pointer overlap #2486

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Nov 27, 2023

What does this PR do?

The updated help text introduced a bug where the help text button container overlaps certain elements. This is caused by an absolute-positioned div that runs along the right-hand-side of the column.

By removing pointer-events from the column and reintroducing it on the button, no content is blocked.

Current example (bug present):
https://editor.planx.dev/testing/test-upload-and-label/preview?analytics=false

Fixed example:
https://2486.planx.pizza/testing/test-upload-and-label/preview?analytics=false

Copy link

github-actions bot commented Nov 27, 2023

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianjon3s
Copy link
Contributor Author

Thanks for quick review @jessicamcinchak !

@ianjon3s ianjon3s merged commit 1f115b5 into main Nov 27, 2023
12 checks passed
@ianjon3s ianjon3s deleted the ian/fix-help-text-pointer-overlap branch November 27, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants