Production deploy #2490
Merged
Production deploy #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Reposition and style help text button * feat: Remove border radius from button
* fix: remove resume on browser refresh to avoid exposing sessionId - Temporarily removing the feature which allows users to resume on browser refresh - The implementation exposed the sessionId which has security implications - Removed the code for the feature and accompanying test * fix: on loading a magic resume link and reading sessionId remove it from the url - Exposing the sessionId has security implications - The sessionId and the user email are required to successfully resume their session - Read the sessionId but then immediately remove it from the url. - This means it's barely visible and not dispalyed for the rest of the session * refactor: reinstate test but check sessionId isn't in url - As per: https://github.com/theopensystemslab/planx-new/pull/2485/files/fcc4df227e74eb399d496b3bb14e69a1617f4512#r1406392300 - Reinstate the test as it can add value checking that the sessionId is *not* in the url after being input by user
ianjon3s
approved these changes
Nov 28, 2023
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.