refactor: Consolidate rich text into component + update styles #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the styling for rich text sits in a standalone CSS file, this PR brings the styles into the
RichTextInput.tsxcomponent and makes small updates to tidy up styling in the editor and public interface.Things to point out
RichTextImage.tsx, however I found no references to this styles in either the code or the output (example below), so I've not imported the newRichContentContainerstyled div to this component..passportremain applied as a CSS class, as there are programatic ways this is applied in the component that I were not able to unpick. Happy to revisit this if it is deemed worthy to refactor.Editor example:
https://2503.planx.pizza/lambeth/content-example
Public example:
https://2503.planx.pizza/lambeth/content-example/preview?analytics=false