fix: Assign missing A4 category #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thoughts - it looks like this will just give us a second "General Policy" list here? |
|
Good spot - this is a weird one! I think it's a CAZ edge case: it looks like the "category" is correctly assigned to CAZ are strangely/uniquely handled because they are a "child" granular passport variable of A4 heirarchy, but fetch from from a unique "dataset" different than A4. |
|
Removed vultr server and associated DNS entries |
|
Fix is working as I'd expect - the frontend is actually grouping these by category 
|
DafyddLlyr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spotted this when testing - it looks like category for article 4s are not being returned by API so the UI is defaulting to
undefined.I don’t think there have really been any recent changes here that could have caused this - there might be another solution (or cause!) I'm missing here so this might be a naive fix...!
Waiting on Pizza to test changes 🚀
Original request URL (undefined):
https://api.2529.planx.pizza/gis/southwark?geom=POLYGON+%28%28-0.0807095109084621+51.50357969225416%2C+-0.08026678402163087+51.50357732850256%2C+-0.0803878763290122+51.50339599741571%2C+-0.0807095109084621+51.50357969225416%29%29&analytics=false