Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Setup prod Nexus key #2557

Merged
merged 1 commit into from
Dec 12, 2023
Merged

chore: Setup prod Nexus key #2557

merged 1 commit into from
Dec 12, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Dec 12, 2023 •
edited
Loading

The most recent prod deploy failed with the following message -

  Diagnostics:
    pulumi:pulumi:Stack (application-production):
      error: Missing required configuration variable 'application:file-api-key-nexus'
      	please set a value using the command `pulumi config set --secret application:file-api-key-nexus <value>`

The value was intentionally not set for production, however it is included in the Pulumi build and I'm uncertain if left blank how this would be handled (looking at tests now).

Rather than add temporary code to check the environment as part of useFilePermission() I think it's simpler for now to set and generate the key, but just keep secret.

@DafyddLlyr DafyddLlyr requested a review from a team December 12, 2023 14:46
jessicamcinchak
jessicamcinchak approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up, agree this is simplest solution!

@DafyddLlyr DafyddLlyr mentioned this pull request Dec 12, 2023
Merged
@DafyddLlyr DafyddLlyr merged commit d885b24 into main Dec 12, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/set-nexus-prod-key branch December 12, 2023 15:14
@github-actions GitHub Actions
Copy link

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak