Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly parse flow slug for invite-to-pay cases for GOV Pay metadata #2560

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Dec 13, 2023

Fixes failed regression tests on main this morning: https://github.com/theopensystemslab/planx-new/actions/runs/7191369572

Now passing on this branch: https://github.com/theopensystemslab/planx-new/actions/runs/7193346466

Gov Pay was throwing this error:

code: "P0102"
description: "Invalid attribute value: metadata. Values must be no greater than 100 characters long"
field: "metadata"

This was only effecting invite-to-pay cases, not "regular" payments initiated on the frontend - as these always have direct access to the flowSlug in state and do not rely on parsing the returnUrl.

Metadata is now correctly captured:
Screenshot from 2023-12-13 10-32-25

Copy link

github-actions bot commented Dec 13, 2023

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit 6479939 into main Dec 13, 2023
17 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/fix-i2p-regression-test-fail branch December 13, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants