fix: decode organisation details from access_token for Uniform authentication
#2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Just a heads up - as the behavior of the Uniform auth server has change we'll need to make a corresponding change to e2e/tests/api-driven/src/invite-to-pay/mocks/server-mocks.yaml
First thought would be to make a hardcoded JWT using something like https://jwt.io/ (changing the payload to be a minimal example match the JWT you have locally which returns the two required values only).
|
I think the string
|
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a failed Southwark submission this morning and found out that there was a new release of the Submissions API Tuesday that changes the response shape of our authentication endpoint.
This change addresses that update, and we'll figure out a process for more pro-active communication and documentation with Idox going forward.
Regression tests failing against this branch but passing locally, going to pick up fix outside of this PR: https://github.com/theopensystemslab/planx-new/actions/runs/7222293774