Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop BOPS_SUBMISSION_URL_* env vars in favour of DB values #2581

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Dec 19, 2023

Take two for this PR - #2504

It looks like I merged this to a parent branch which was already merged to main so this never got picked up πŸ€¦β€β™‚οΈ

I'll rebase this now πŸ‘

What does this PR do?

  • Drop BOPS_SUBMISSION_URL_* env vars
  • Drop BOPS_API_ROOT_DOMAIN env vars
  • Read these values from the DB instead

Why?

  • Medway require their BOPS env added to PlanX and it now seems like a perfect time to tidy this up a little!

Depends on theopensystemslab/planx-core#212

Before merging this I'd be grateful for another pair of eyes on db values now populated on prod and staging. This query is giving me the expected results -

query GetBopsSubmissionURLs {
  teams(where: {integrations: {team_id: {_is_null: false}}}) {
    slug
    integrations {
      production_bops_submission_url
      staging_bops_submission_url
    }
  }
}

Once merged I'll also remove these from the real .env files on S3 also πŸ‘Œ

@DafyddLlyr DafyddLlyr force-pushed the dp/remove-bops-env-vars branch from d4f5145 to ed92e86 Compare December 19, 2023 15:47
@DafyddLlyr DafyddLlyr force-pushed the dp/remove-bops-env-vars branch from 69f352f to e45655d Compare December 19, 2023 16:09
Copy link

github-actions bot commented Dec 19, 2023

Removed vultr server and associated DNS entries

@DafyddLlyr
Copy link
Contributor Author

This is ready for (re) review! The only changes from the previous PR are updates to test in this commit.

@DafyddLlyr DafyddLlyr requested a review from a team December 20, 2023 08:51
@DafyddLlyr DafyddLlyr marked this pull request as ready for review December 20, 2023 08:51
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this merge bug - happy for this to move forward, a very nice tidy up!

@DafyddLlyr DafyddLlyr merged commit af36d41 into main Dec 20, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/remove-bops-env-vars branch December 20, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants