chore: Drop BOPS_SUBMISSION_URL_*
env vars in favour of DB values
#2581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two for this PR - #2504
It looks like I merged this to a parent branch which was already merged to
main
so this never got picked up π€¦ββοΈI'll rebase this now π
What does this PR do?
BOPS_SUBMISSION_URL_*
env varsBOPS_API_ROOT_DOMAIN
env varsWhy?
Depends on theopensystemslab/planx-core#212
Before merging this I'd be grateful for another pair of eyes on db values now populated on prod and staging. This query is giving me the expected results -
Once merged I'll also remove these from the real
.env
files on S3 also π