fix: Detect presence of httpOnly cookie
#2595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
|
Closed in order to merge this into a more robust solution for #2591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the problem?
Following the deploy of #2591, the login / logout flow on staging is now broken. I believe that this is due to the fact that the browser cannot even detect the presence of the
httpOnlycookie, so thehasJWT()function is always returning false on staging.What's the solution?
Add a second cookie without the
httpOnlyflag which can be used as a proxy to detect the presence of thejwtcookie.Solution found here - https://stackoverflow.com/a/63877877