fix: Drop redundant sanitation for Find and Replace #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Dec 21, 2023
| @@ -264,280 +264,4 @@ describe("string replacement", () => { | |||
| expect(res.body.error).toMatch(/Failed to find and replace/); | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("HTML replacement", () => { | |||
There was a problem hiding this comment.
Dropping this suite does not affect the percentage of test coverage, and I'll make sure it gets picked up in an E2E test that can genuinely test this.
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/drop-find-replace-sanitation
branch
from
4ba0226 to
4bebb99
Compare
jessicamcinchak
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes sanitation step from Find and Replace API endpoint
Why?
This is now redundant following #2551 as this step is handled by Hasura in update of the flow table.
Context
Introduced in #2488 as an inital attempt at handling sanitation.