Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Team settings page and routes #2604

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Dec 22, 2023

What does this PR do?

  • Makes the Settings component more generic, so it can be reused in different contexts
  • Splits current tabs up across "Team Settings" and "Flow Settings"
  • Just a UI change, nothing is wired up
Screen.Recording.2023-12-22.at.18.08.57.mov

Copy link

github-actions bot commented Dec 22, 2023

Removed vultr server and associated DNS entries

@ianjon3s
Copy link
Contributor

ianjon3s commented Jan 2, 2024

This is great, much needed with the forthcoming overhaul of editor design powers.

One thing I've spotted, when you have a Team Settings tab open and you select Team Settings again from the menu, it routes to a /settings subfolder which displays as blank (not an issues with Global or Flow Settings).

Example: https://2604.planx.pizza/barking-and-dagenham/settings/settings

@DafyddLlyr
Copy link
Contributor Author

This is great, much needed with the forthcoming overhaul of editor design powers.

One thing I've spotted, when you have a Team Settings tab open and you select Team Settings again from the menu, it routes to a /settings subfolder which displays as blank (not an issues with Global or Flow Settings).

Example: https://2604.planx.pizza/barking-and-dagenham/settings/settings

Thanks for spotting this! Should be fixed now 🙂

Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, working as expected.

@DafyddLlyr DafyddLlyr merged commit 1213bc9 into main Jan 2, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/team-settings-panel branch January 2, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants