wip: UI setup for team design settings #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Jan 11, 2024
| @@ -95,6 +95,7 @@ const Root = styled(Box)(({ theme }) => ({ | |||
| left: 0, | |||
| right: 0, | |||
| minHeight: `calc(100% - ${HEADER_HEIGHT}px)`, | |||
| zIndex: "2000", | |||
There was a problem hiding this comment.
We don't do this consistently anywhere yet, but ideally we'd assign these variables at the theme level to avoid conflicts.
Might be a nice quick tidy up to pick up at some point?
Docs:
There was a problem hiding this comment.
Ah yes, this is a leftover shim from the previous incarnation of the help text button, which was using fixed positioning and was being pushed into visibility above the setting panel.
I'll remove this for now and look to update the z-index hierarchy at the theme level in a separate PR.
| @@ -27,7 +27,7 @@ const Root = styled(Box, { | |||
| }), | |||
| })); | |||
|
|
|||
| export default function InputRow({ | |||
| export default function EditorRow({ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Builds UI for editor team design settings, currently hidden behind a feature flag.
Example:
https://2643.planx.pizza/barnet/settings/design
Feature flag to toggle design settings:
window.featureFlags.toggle("SHOW_TEAM_SETTINGS")