-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add custom domains to CORS allowlist #2666
Conversation
71a6409
to
33a60f4
Compare
Removed vultr server and associated DNS entries |
6b323c1
to
b11c160
Compare
@@ -141,6 +141,7 @@ services: | |||
SLACK_WEBHOOK_URL: ${SLACK_WEBHOOK_URL} | |||
ORDNANCE_SURVEY_API_KEY: ${ORDNANCE_SURVEY_API_KEY} | |||
MINIO_PORT: ${MINIO_PORT} | |||
CORS_ALLOWLIST: ${EDITOR_URL_EXT} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is just a "derived" env var, we actually don't need to add it to the .env
files and we can just populate it here.
If this is unclear / unhelpful I can add it to the .env
and .env.example
files.
0abc5a9
to
8a6b2a2
Compare
8a6b2a2
to
183eb8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pizza working as expected for me, thanks for getting to the bottom of this one!
What does this PR do?
How is this resolved?
CORS_ALLOWLIST
To test