Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wire up design settings (button colour) #2669

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jan 16, 2024

What does this PR do?

image

@DafyddLlyr DafyddLlyr changed the base branch from main to dp/wire-up-team-design-form January 16, 2024 17:12
Copy link

github-actions bot commented Jan 16, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/wire-up-button-form branch from 6f06ae0 to 2f737c2 Compare January 17, 2024 08:01
@DafyddLlyr DafyddLlyr requested a review from a team January 17, 2024 08:03
@DafyddLlyr DafyddLlyr marked this pull request as ready for review January 17, 2024 08:03
@ianjon3s
Copy link
Contributor

ianjon3s commented Jan 17, 2024

If we include a contrast checker here is must be able to check whether the selected colour contrasts with white or black.

Currently when selecting a light colour (for example Camden's button colour of #ead95b), the text in the button is correctly selected as black, but the form cannot be saved due to validation.
image

I think we may be best placed to do without a contrast checker here.

Base automatically changed from dp/wire-up-team-design-form to main January 17, 2024 16:34
@Mike-Heneghan
Copy link
Contributor

Trying this out on the pizza I noticed that the new form does update the DB but the change isn't seen in the flows.

Is that part of the scope of this or is that work elsewhere / to be done later?

@DafyddLlyr DafyddLlyr force-pushed the dp/wire-up-button-form branch from a542870 to 64793b4 Compare January 17, 2024 16:41
@DafyddLlyr
Copy link
Contributor Author

@Mike-Heneghan Sorry should have clarified that - this code change in this PR doesn't update the button colour directly, that was updated in this PR - #2658

I've just merged that and rebased this PR though so this should now work end-to-end 😄

Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and working as expected for me on the pizza now 🥳

@DafyddLlyr DafyddLlyr merged commit 58f9108 into main Jan 17, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/wire-up-button-form branch January 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants