feat: Wire up design settings (text link colour) #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/wire-up-link-colour
branch
from
c66bfd1 to
53ef55a
Compare
DafyddLlyr
force-pushed
the
dp/wire-up-link-colour
branch
from
53ef55a to
82c7b70
Compare
DafyddLlyr
force-pushed
the
dp/wire-up-link-colour
branch
from
82c7b70 to
1dbb181
Compare
|
Testing this on both the pizza link and locally, if a colour with adequate contrast is selected, the colour saves and is applied correctly in the app. If a failing contrast colour is selected, the save button takes no effect, however there is no warning given about contrast ratio. |
Good catch thank you! Not sure how I missed this sorry 😅 Taking a look now... |
|
This should be resolved now - something which got mixed in merge conflicts I think.
|
ianjon3s
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?