feat: Use ImgInput for logo upload

[DafyddLlyr]

What does this PR do?

• Small refactor mentioned here - feat: Wire up favicon form #2680 (comment)
• Use ImgInput component instead of PublicFileUploadButton
• This allows us to remove images and view them, and is a little more consistent with how we handle images elsewhere in the Editor
• Restricts logo to SVG or PNG

[github-actions]

Removed vultr server and associated DNS entries

[Mike-Heneghan]

I've been noticing a small bug where when either of the forms which have the ImgInput have the "Reset Changes" selected a box with View and Change appears in the top left of the screen.

Screen.Recording.2024-01-20.at.14.51.17.mov

[Mike-Heneghan]

I think this might be out of scope but on the pizza I noticed without a logo the preview makes it look as if it'll default to just the team name:

Although in the service it looks like it's got the full path including "PlanX" in the top left.

I'm not sure if I'm doing something weird or it's a quirk of the environment?

[Mike-Heneghan]

It's great seeing this all come together 🥳

I've got a few questions/comments which are maybe slightly more general testing notes after playing around with the feature more today.

I don't think they block this going out and maybe being reviewed/resolved in a follow up PR?

Whatever you thinks best 👍

[Mike-Heneghan]

nit:

I think it's out of scope at the moment but I just noticed all the help guide links are to PlanX.

Would it be worth adding a wee "todo" comment?

<Link href="https://www.planx.uk">
  See our guide for setting theme colours and logos (TODO)
</Link>

[DafyddLlyr]

Very good catch - will update these...!

[DafyddLlyr]

I think this might be out of scope but on the pizza I noticed without a logo the preview makes it look as if it'll default to just the team name:

I'll update this also thanks!

[DafyddLlyr]

I've been noticing a small bug where when either of the forms which have the ImgInput have the "Reset Changes" selected a box with View and Change appears in the top left of the screen.

Yep, I can re-create this. Taking a look!

[DafyddLlyr]

@Mike-Heneghan Thanks for the review and testing - much appreciated! These comments should all be addressed in 5703093

[Mike-Heneghan]

Thanks for updating to resolve that feedback @DafyddLlyr 🙌

I've seen some slightly odd behaviour on the pizza with what seems like the logo resetting to what it was originally if other forms have updates:

Screen.Recording.2024-01-22.at.10.26.38.mov

I'm not sure if it's a caching setting in my browser or maybe the different forms are loading with the initial values on first render and overwriting the changed logo when the other forms are submitted?

[DafyddLlyr]

I've seen some slightly odd behaviour on the pizza with what seems like the logo resetting to what it was originally if other forms have updates:

Ah this is caused by a shared form config but not a shared form state 🤦 Maybe over simplifying things in #2684

As it's not introduced in this PR (and may be a change which touches a few files) I'll pick it up on a new branch and merge this as-is for now 👍

[DafyddLlyr]

Thanks for updating to resolve that feedback @DafyddLlyr 🙌

I've seen some slightly odd behaviour on the pizza with what seems like the logo resetting to what it was originally if other forms have updates:

Screen.Recording.2024-01-22.at.10.26.38.mov
I'm not sure if it's a caching setting in my browser or maybe the different forms are loading with the initial values on first render and overwriting the changed logo when the other forms are submitted?

@Mike-Heneghan This is addressed in the following PR - #2688