chore: account for title boundaries in document templates #2696
Conversation
| @@ -126,7 +126,7 @@ export default function PlotNewAddress(props: PlotNewAddressProps): FCReturn { | |||
| drawType="Point" | |||
| geojsonData={JSON.stringify(props?.boundary)} | |||
| geojsonColor="#efefef" | |||
| geojsonBuffer="10" | |||
| geojsonBuffer={10} | |||
There was a problem hiding this comment.
Should have spotted this on the map PR sorry - but would this be a breaking change for the map component?
I'm very certain it's only us using this prop currently so it's not a blocker here right now, but maybe we should have gone to v0.8.0
I'd be happy with continuing as-is and we can maybe just let BOPS know tomorrow to be aware if they're relying on this. Linting should catch it anyway before it causes too many headaches!
There was a problem hiding this comment.
We'd previously been using a mix of strings & numbers - Lit should smartly evaluate all these the same so no map version bump necessary!
MapProps in planx-core don't actually correspond to Lit types - it's a bit of a weird headache!
There was a problem hiding this comment.
Thanks for the explanation - agreed that it's helpful yet headachey 😅
|
Removed vultr server and associated DNS entries |
See theopensystemslab/planx-core#269
Not a blocker to merging public-facing aspects of title boundaries to production, but we do want to make sure any maps displayed on document templates in submission zips have proper attribution sooner than later.
To test:
properties.planx_user_action