Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Post correct payload to /download-application endpoint #2698

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix: Post correct payload to /download-application endpoint #2698

merged 1 commit into from
Jan 24, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jan 24, 2024 •
edited
Loading

What's the problem?

To test

  • Start an application on a submission service on staging
  • Save, then click "Download your application (.csv)"
  • This will fail and return a 400 plus invalid CSV ❌
  • Start an application on a submission service on Pizza
  • Save, then click "Download your application (.csv)"
  • This will return a 200 plus valid CSV ✅

@DafyddLlyr DafyddLlyr requested a review from a team January 24, 2024 12:15
Mike-Heneghan
Mike-Heneghan approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough testing notes @DafyddLlyr!

I've replicated the error on staging and then successfully downloaded the application as a csv locally using your branch and on the pizza 👍

editor.planx.uk/src/ui/public/FileDownload.tsx
Comment on lines +20 to +24
export default function FileDownload({
data,
filename,
text,
}: Props): FCReturn {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how the props are extracted here!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr changed the title fix: Post correct paylaod to /download-application endpoint fix: Post correct payload to /download-application endpoint Jan 24, 2024
@DafyddLlyr DafyddLlyr merged commit c318254 into main Jan 24, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/csv-zod-error branch January 24, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Heneghan Mike-Heneghan Mike-Heneghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @Mike-Heneghan