Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update DrawBoundary upload key from proposal.drawing.locationPlan to locationPlan #2758

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Feb 6, 2024

This one isn't exposed as editor props, so it'll be live across services as soon as it's merged ! We'll coordinate merge with other file key changes.

Related to theopensystemslab/planx-core#289 & theopensystemslab/planx-data-migrations#7

BOPS logic is repeated in the editor's Send component still for frontend CSV generation - I'll take a look at properly refactoring using the planx-core public client today so we don't have to repeat the same find-and-replace across the v1 tagging functions.

Copy link

github-actions bot commented Feb 6, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review February 6, 2024 11:58
@jessicamcinchak jessicamcinchak requested a review from a team February 6, 2024 11:58
@jessicamcinchak jessicamcinchak merged commit 539b774 into main Feb 8, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/update-locationPlan-file-key branch February 8, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants