Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Capture _requestedFiles from DrawBoundary component #2769

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

DafyddLlyr
Copy link
Contributor

What does this PR do?

Comment on lines +140 to +142
const { required, recommended, optional } = passport.data?.[
PASSPORT_REQUESTED_FILES_KEY
] || { required: [], recommended: [], optional: [] };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to have another look at moving this repeated code fragment to the store / a shared location in another PR as my approach here was leading to failing tests f74f9da

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR here - #2770

@DafyddLlyr DafyddLlyr requested a review from a team February 9, 2024 10:24
Copy link

github-actions bot commented Feb 9, 2024

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are great here, thanks for picking this up !

@DafyddLlyr DafyddLlyr merged commit 6fb80d6 into main Feb 9, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drawboundary-requested-files branch February 9, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants