feat: Reposition change button, add dialog on change #2774
Conversation
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/reposition-change-button-again
branch
from
ae2dc6a to
36f2b60
Compare
DafyddLlyr
force-pushed
the
dp/reposition-change-button-again
branch
from
36f2b60 to
0486c1f
Compare
| cancelText="No" | ||
| > | ||
| <Typography> | ||
| If you change this answer, you’ll need confirm all the other answers |
There was a problem hiding this comment.
typo: ...you'll need _to_ confirm...
also personal preference: i'd keep it very short & simple & delete the second "because" sentence !
There was a problem hiding this comment.
Copy/pasted content from Trello - didn't check for typos 🤦
Agreed that for me the shorter version is clearer / more meaningful. As this is content from Nomensa I'll pass it forward as is (with typo fixed!) but raise this at PO testing 👍
| <Button onClick={onCancel}>{cancelText}</Button> | ||
| <Button onClick={onConfirm}>{confirmText}</Button> | ||
| </DialogActions> | ||
| </Dialog> |
There was a problem hiding this comment.
Nice to see the proper MUI component here! Would be great to replace the native window alert on "restart application" with this component too 🔖
There was a problem hiding this comment.
I have this planned as a follow up! Should have made a comment in the description 😄
What does this PR do?
Screen.Recording.2024-02-09.at.17.09.43.mov