Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mh/remove feedback fish #2775

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Mh/remove feedback fish #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12f4396
chore: remove feedback fish related content from Footer
Mike-Heneghan Feb 9, 2024
49646c9
chore: delete feedback fish phase banner
Mike-Heneghan Feb 9, 2024
5ebe07c
chore: remove feedback fish submission logic
Mike-Heneghan Feb 9, 2024
8b9cc9f
chore: remove Feedback Fish CSV download functionality
Mike-Heneghan Feb 12, 2024
27018fa
chore: remove feedback-fish from infra
Mike-Heneghan Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ jobs:
REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
REACT_APP_API_URL: https://api.${{ env.FULL_DOMAIN }}
REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
REACT_APP_HASURA_URL: https://hasura.${{ env.FULL_DOMAIN }}/v1/graphql
REACT_APP_SHAREDB_URL: wss://sharedb.${{ env.FULL_DOMAIN }}
# needed because there's no API to change google's allowed OAuth URLs
Expand All @@ -224,7 +223,6 @@ jobs:
REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
REACT_APP_API_URL: https://api.${{ env.FULL_DOMAIN }}
REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
REACT_APP_HASURA_URL: https://hasura.${{ env.FULL_DOMAIN }}/v1/graphql
REACT_APP_SHAREDB_URL: wss://sharedb.${{ env.FULL_DOMAIN }}
REACT_APP_GOOGLE_OAUTH_OVERRIDE: https://api.editor.planx.dev
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/push-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ jobs:
working-directory: editor.planx.uk
env:
REACT_APP_API_URL: https://api.editor.planx.dev
REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
REACT_APP_HASURA_URL: https://hasura.editor.planx.dev/v1/graphql
REACT_APP_SHAREDB_URL: wss://sharedb.editor.planx.dev
REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/push-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ jobs:
working-directory: editor.planx.uk
env:
REACT_APP_API_URL: https://api.editor.planx.uk
REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
REACT_APP_HASURA_URL: https://hasura.editor.planx.uk/v1/graphql
REACT_APP_SHAREDB_URL: wss://sharedb.editor.planx.uk
REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
Expand Down
20 changes: 0 additions & 20 deletions api.planx.uk/modules/admin/controller.ts
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions api.planx.uk/modules/admin/docs.yaml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions api.planx.uk/modules/admin/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,10 @@ import { getHTMLExport, getRedactedHTMLExport } from "./session/html";
import { generateZip } from "./session/zip";
import { getSessionSummary } from "./session/summary";
import { getDigitalPlanningApplicationPayload } from "./session/digitalPlanningData";
import { validate } from "../../shared/middleware/validate";
import { downloadFeedbackCSVSchema } from "./service/feedback/types";
import { downloadFeedbackCSV } from "./controller";

const router = Router();

router.use("/admin/", usePlatformAdminAuth);
router.get(
"/admin/feedback",
validate(downloadFeedbackCSVSchema),
downloadFeedbackCSV,
);

// TODO: Split the routes below into controller and service components
router.get("/admin/session/:sessionId/xml", getOneAppXML);
Expand Down
151 changes: 0 additions & 151 deletions api.planx.uk/modules/admin/service/feedback/downloadFeedbackCSV.test.ts
View file
Open in desktop

This file was deleted.

85 changes: 0 additions & 85 deletions api.planx.uk/modules/admin/service/feedback/downloadFeedbackCSV.ts
View file
Open in desktop

This file was deleted.

Loading
Loading