-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move hasPlanningData
value to team_integrations
table
#2776
Conversation
2abb1b6
to
b48ab78
Compare
Removed vultr server and associated DNS entries |
b48ab78
to
466413d
Compare
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
466413d
to
a4c74c6
Compare
UPDATE team_integrations | ||
SET has_planning_data = COALESCE((teams.settings->>'hasPlanningData')::boolean, false) | ||
FROM teams | ||
WHERE team_integrations.team_id = teams.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've manually re-ran this on the Pizza as the data sync happens after the Hasura migrations have already ran 🌀
This won't be necessary on staging and production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good shout! I was also slightly bamboozled when everything appeared to be false
nit I maybe just need to look at this with fresh eyes tomorrow although when I run the query on the pizza I get more records than your list:
I get the same but additionally: gateshead & open-digital-planning i.e.
I'm not sure if it's a problem as that seems to match what we'd see on Although, the difference triggered a wee warning bell. I'll have a proper look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and working on the pizza as expected for me 👍
What does this PR do?
team_integrations.has_planning_data
columnteams.settings-->"hasPlanningData"
teams.settings-->"hasPlanningData"
value not removed / tidied up, we can maybe address this when we just stop theteam_settings
column?Data migration
On the Pizza, the following query can be made to get a list of all teams which have
has_planing_data
set totrue
-This gives the following list which matches the previous value of the hardcoded
digitalLandOrganisations
(plus the recently addedtewkesbury
,barking-and-dagenham
&west-berkshire
).Testing