Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: format Airbrake API errors for more readable Slack" #2794

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

jessicamcinchak
Copy link
Member

Reverts #2781

Looks like this is actually a bit worse, so reverting! This should have been a "Failed to send to BOPS" error equivalent to the original PR "before" screenshot:
Screenshot from 2024-02-15 11-43-31

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I hit yesterday (sorry for not flagging this sooner) was the undocumented types which Airbrake expects - #2791

Maybe an alternative to look at?

Copy link

github-actions bot commented Feb 15, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit 6b625b0 into main Feb 15, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the revert-2781-jess/airbrake-log-formatting branch February 15, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants