-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplified change logs on publish #2811
Merged
jessicamcinchak
merged 10 commits into
jess/fetch-published-portals-on-publish
from
jess/publish-change-diffs
Feb 28, 2024
Merged
feat: simplified change logs on publish #2811
jessicamcinchak
merged 10 commits into
jess/fetch-published-portals-on-publish
from
jess/publish-change-diffs
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
changed the title
feat : simplified change logs on publish
feat: simplified change logs on publish
Feb 23, 2024
Removed vultr server and associated DNS entries |
DafyddLlyr
reviewed
Feb 26, 2024
editor.planx.uk/src/pages/FlowEditor/components/PreviewBrowser.tsx
Outdated
Show resolved
Hide resolved
DafyddLlyr
reviewed
Feb 26, 2024
…theopensystemslab/planx-new into jess/publish-change-diffs
jessicamcinchak
changed the base branch from
main
to
jess/fetch-published-portals-on-publish
February 27, 2024 09:59
…ss/publish-change-diffs
…theopensystemslab/planx-new into jess/publish-change-diffs
jessicamcinchak
commented
Feb 28, 2024
@@ -68,7 +72,7 @@ const DebugConsole = () => { | |||
); | |||
}; | |||
|
|||
function PublishChangeItem(props: any) { | |||
function AlteredNodeItem(props: any) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware there's some lingering any
's around this file that I haven't cleaned up - one on my radar to come back to, want to keep up momentum with logic changes first !
DafyddLlyr
approved these changes
Feb 28, 2024
jessicamcinchak
merged commit Feb 28, 2024
5c3b104
into
jess/fetch-published-portals-on-publish
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #2783
Changes based on feedback from publishing conversations this week:
platformAdmins
teamEditor
access to, or show as plain text otherwise