Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplified change logs on publish #2811

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Feb 23, 2024

Branched from #2783

Changes based on feedback from publishing conversations this week:

  • "Drafts all the way down" route is too confusing to explain to average user, so only make it visible to platformAdmins
  • Adds a simple badge to indicate there are unpublished changes (hidden if 0 or errors)
    • Ideally I think this would be text rather than count, but MUI Badge is a bit limiting here!
    • In future, goal is to repeat badge on any portal nodes in graph that have changed
  • Trying out a very mvp version of a simplified publish change log message
    • Summarise updated & deleted nodes, with option to expand to full list (full list is exact same as default view now)
    • Link to any nested flows that you have teamEditor access to, or show as plain text otherwise
    • In future, also add expandable details for each nested flow like last published date, summary message, etc
    • Styles here are quite rough, but will be easy to revisit later once we have a new shape of "summary content"

Screenshot from 2024-02-23 14-49-45

Screenshot from 2024-02-28 09-00-25

Screenshot from 2024-02-28 08-58-38

@jessicamcinchak jessicamcinchak changed the title feat : simplified change logs on publish feat: simplified change logs on publish Feb 23, 2024
Copy link

github-actions bot commented Feb 23, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak changed the base branch from main to jess/fetch-published-portals-on-publish February 27, 2024 09:59
@jessicamcinchak jessicamcinchak marked this pull request as ready for review February 28, 2024 08:14
@jessicamcinchak jessicamcinchak requested a review from a team February 28, 2024 08:22
@@ -68,7 +72,7 @@ const DebugConsole = () => {
);
};

function PublishChangeItem(props: any) {
function AlteredNodeItem(props: any) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware there's some lingering any's around this file that I haven't cleaned up - one on my radar to come back to, want to keep up momentum with logic changes first !

@jessicamcinchak jessicamcinchak merged commit 5c3b104 into jess/fetch-published-portals-on-publish Feb 28, 2024
10 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/publish-change-diffs branch February 28, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants