fix: don't include ODP Schema in submission zip by default #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
commented
Feb 23, 2024
| expect.anything(), | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
these tests just got re-organised under a new describe below, not removed
jessicamcinchak
deleted the
jess/conditionally-include-ODP-schema-in-zip
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollsback #2804 and relies on theopensystemslab/planx-core#310
Staging applications to Uniform DMS including JSON errored for Southwark, and it's not looking promising for others. This will still include the JSON in 'Send to email' whenever a supported application type, but never include in the Uniform zip.
This branch also fixes failing regression tests on
main: https://github.com/theopensystemslab/planx-new/actions/runs/8021970968