test: FeedbackPhaseBanner component functionality and accessibility

[Mike-Heneghan]

What

• Add tests for the FeedbackPhaseBanner component functionality and accessibility

Why

• Improving test coverage

[github-actions]

Removed vultr server and associated DNS entries

[DafyddLlyr]

One small change required!

[DafyddLlyr]

This isn't something we're currently enforcing (maybe we should?) but fireEvent is rarely needed and we can rely on user for an experience which is closer to the real DOM.

Instead of importing this we can can use the user returned from setup() like so -

test("clicking on feedback link calls handleFeedbackClick", async () => {
  const { getByText, user } = setup(
    <FeedbackPhaseBanner
      handleFeedbackClick={handleFeedbackClick}
      handleReportAnIssueClick={handleReportAnIssueClick}
    />,
  );

  await user.click(getByText("feedback"));
  expect(handleFeedbackClick).toHaveBeenCalledTimes(1);
});

The notable change here is that this is now an async function - I think the test will just fail without the await before user.click().

Docs: https://testing-library.com/docs/dom-testing-library/api-events/

[Mike-Heneghan]

Fixed here: 2035632

[DafyddLlyr]

Thanks for the quick fixes here! ✅

[Mike-Heneghan]

Design & implement in-house feedback feature & retire Feedback Fish