feat: update and redirect /preview to /published
#2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
changed the base branch from
main
to
jess/fetch-published-portals-on-publish
DafyddLlyr
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Code-only review looks great, thanks for the clear PR description 👍
Testing Pizza now and will then give a ✅
I've added a comment to this trello ticket to take into consideration the renaming of preview → published throughout the code base more generally.
| @@ -92,7 +92,7 @@ export const getTeamFromDomain = async (domain: string) => { | |||
| /** | |||
| * Prevents accessing a different team than the one associated with the custom domain. | |||
| * e.g. Custom domain is for Southwark but URL is looking for Lambeth | |||
| * e.g. https://planningservices.southwark.gov.uk/lambeth/some-flow/preview | |||
| * e.g. https://planningservices.southwark.gov.uk/lambeth/some-flow | |||
DafyddLlyr
approved these changes
Mar 4, 2024
|
One thing for BOPS dev call - seems super unlikely, but we should double-check if they hold any references to our service URLs outside of the new payload. |
jessicamcinchak
merged commit e964a15
into
jess/fetch-published-portals-on-publish
17 checks passed
jessicamcinchak
deleted the
jess/fetch-published-portals-on-publish-reroute-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last big functional update for #2783 !
Will rebase this branch once pizza builds against main. Opening as separate PR for easier review - this touches a lot of files.
Testing:
/publishednow (still disabled if flow is unpublished)/publishedin the URL; you can resume successfully using those magic links/publishedsuccessfully/previewredirects to/publishedand keeps query search params like analytics, sessionId, email, etcOther considerations:
/previewchore: update any Editor/previewURLs to/publishedplanx-core#318 (can be merged later once publishing work is on staging, no direct dependencies here)isPreviewOnlyDomainis especially confusing now, I think we'll want to reconsider our internal usage of "preview" environments and related terms like "standalone" - but let's address this separately as there aren't any external communication dependencies that will impact PO testing